Standard library support for guests #759
Open
+1,067
−425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from #631
…th_small_additions
…th_small_additions
matthiasgoergens
changed the title
lispc
reviewed
Dec 16, 2024
| unreachable!(); | ||
| } | ||
| #[cfg(not(target_arch = "riscv32"))] | ||
| unimplemented!("Halt is not implemented for this target: {}", exit_code); |
There was a problem hiding this comment.
unimplemented!("Halt is not implemented for this target, exit_code: {}", exit_code); would be easier to understand
lispc
reviewed
Dec 16, 2024
| @@ -0,0 +1,31 @@ | |||
| { | |||
There was a problem hiding this comment.
in future, when users run ceno-cli init-project ..., will this riscv32im-ceno-zkvm-elf.json be put into their workspace, (allow editting), or actually this file is not something they can change, bounded to "ceno plaform"?
for the latter case, this file should be in rt folder instead of example folder?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard library support for guests works, but this PR needs some polishing and depends on a lot of other PRs that should go in first, to make this one easier to review. Nevertheless, you can have a look and try this one out, if you want.
Depends on:
riscvcrate dependency #758